CFE-4549: Made copy_file atomic #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
requested changes
Aug 6, 2025
Contributor
|
Another problem is that someone might be writing to the input file while you are copying it. You can use file locks like |
larsewi
requested changes
Aug 7, 2025
larsewi
reviewed
Aug 7, 2025
larsewi
reviewed
Aug 7, 2025
larsewi
reviewed
Aug 7, 2025
larsewi
reviewed
Aug 7, 2025
victormlg
force-pushed
the
atomic_copy
branch
2 times, most recently
from
bd4ba35 to
b612cf0
Compare
larsewi
requested changes
Aug 11, 2025
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Looks good 🚀 Just a couple of comments
Made copy_file atomic using lock-free wack-a-mole algorithm Ticket: CFE-4549 Signed-off-by: Victor Moene <[email protected]>
Signed-off-by: Victor Moene <[email protected]>
larsewi
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.